fix: validate subprotocol mqtt #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
suggested changes
Oct 5, 2023
Vilayat-Ali
force-pushed
the
vilayat/fix/validate-response-header-mqtt
branch
from
2c87dcf
to
a20ed3a
Compare
|
@swanandx any plans on fixing clippy suggestions? Please vet this PR and merge if it looks good to go. Test against a broker that supports websocket |
me must haha, should we open separate PR for it ( would need to sync up this branch after merging it )? or just fix it in this one?
will do! |
swanandx
reviewed
Oct 6, 2023
|
@Vilayat-Ali please go through the changes suggested by @swanandx and the last two commits made to fix the PR along the repo code style. Please note the reorg of code and the naming conventions used. Congrats on your first PR being merged! 🎊 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
Added validation to check for response headers for websocket subprotocol for "mqtt" and returns a new error
WebsocketSubprotocolvariant if absent.Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.