This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix typo on README #122
Open
Fix typo on README #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 93.65% 92.31% -1.35%
==========================================
Files 11 11
Lines 1309 1080 -229
==========================================
- Hits 1226 997 -229
Misses 45 45
Partials 38 38
Continue to review full report at Codecov.
|
bxcodec
reviewed
Jan 21, 2021
| @@ -90,7 +90,7 @@ Support Only For : | |||
| --- | |||
|
|
|||
| Unfortunately this library has some limitation | |||
| * It does not support private fields. Make sure your structs fields you intend to generate fake data for are public, it would otherwise trigger a panic. You can however omit fields using a tag skip `faker:"-"` on your private fields. | |||
| * It does not support private fields. Make sure your structs fields you intend to generate fake data for are public, it would otherwise trigger a panic. You can however omit fields using a tag skip `faker:"-"` on your public fields. | |||
There was a problem hiding this comment.
I think both for private and public should be added the ignore tag faker:"-". I recommend removing this instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this to be a typo, private fields can't "be skipped" because they can't be used anyway, so that option would be useful public fields only.