Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no_std and add CI check #1

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

pinkforest
Copy link

As is established standard in curve25519-dalek and fiat-crypto

@pinkforest
Copy link
Author

pinkforest commented Feb 29, 2024

@bwesterb I fixed Cargo manifest to make sure it doesn't break no_std and uses the resolver that is used by default with workspaces which we're used to - but this crate didn't use workspace so it was implicitly using resolver ="1" that caused it to bring getrandom even when only building - which broke no_std support.

It seems kyber1024 feature is broken - I'll mark it ignored for now

@pinkforest pinkforest changed the title ci: Add no_std check Fix no_std and add CI check Feb 29, 2024
@bwesterb
Copy link
Owner

Thanks for this, and please accept my apologies for the late review. I saw it, and then completely forgot about it.

@bwesterb bwesterb merged commit c9de5e3 into bwesterb:master Jun 20, 2024
@bwesterb
Copy link
Owner

bwesterb commented Jun 20, 2024

Had to revert because of build failure

error: `#[panic_handler]` function required, but not found

error: unwinding panics are not supported without std

@bwesterb
Copy link
Owner

Removing all panic! didn't work. Probably some panics in dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants