#31 fixes issue with metric not being specified

business-science · May 31, 2024 · 6c33f88 · 6c33f88
1 parent ca0e647
commit 6c33f88
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -52,6 +52,6 @@ Suggests:
     lubridate,
     knitr,
     rmarkdown
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.1
 VignetteBuilder: knitr
 Roxygen: list(markdown = TRUE)
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,16 @@
 # modeltime.ensemble (development version)
 
+- #31 Fixes issue with metric argument not being specified:
+
+```r 
+Error in `tune::show_best()`:
+! `...` must be empty.
+✖ Problematic argument:
+• ..1 = metric
+ℹ Did you forget to name an argument?
+```
+
+
 # modeltime.ensemble 1.0.3
 
 - Resubmit to CRAN  (following timetk archival)

diff --git a/R/ensemble_model_spec.R b/R/ensemble_model_spec.R
@@ -309,7 +309,7 @@ generate_stacking_results <- function(object,
             )
         )
 
-        best_params_tbl <- tune_results_tbl %>% tune::show_best(metric, n = 1)
+        best_params_tbl <- tune_results_tbl %>% tune::show_best(metric = metric, n = 1)
 
         if (control$verbose) {
             cli::cli_alert_success("Finished tuning Model Specification.")