fix language issue for non us people

bullhorn · Nov 6, 2019 · bf50f88 · bf50f88
1 parent 83135d2
commit bf50f88
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/src/app/services/settings/settings.service.ts b/src/app/services/settings/settings.service.ts
@@ -93,7 +93,7 @@ export class SettingsService {
       }
       this.transferState.set(LANGUAGE_KEY, language);
     } else {
-      language = this.transferState.get(LANGUAGE_KEY, navigator.language);
+      language = this.transferState.get(LANGUAGE_KEY, undefined);
       if (!language) {
         language = SettingsService.settings.supportedLocales.filter((locale: string) => {
           return navigator.language === locale;

diff --git a/src/app/sidebar/sidebar.component.html b/src/app/sidebar/sidebar.component.html
@@ -7,9 +7,9 @@
 <novo-loading *ngIf="loading"></novo-loading>
 <ng-container *ngIf="!loading">
   <div class="filters">
-    <app-sidebar-filter field="publishedCategory(id,name)" title="Category" [filter]="filter" (checkboxFilter)="updateFilter('publishedCategory', $event)" ></app-sidebar-filter>
-    <app-sidebar-filter field="address(state)" title="State" [filter]="filter" (checkboxFilter)="updateFilter('address(state)', $event)"></app-sidebar-filter>
-    <app-sidebar-filter field="address(city)" title="City" [filter]="filter" (checkboxFilter)="updateFilter('address(city)', $event)"></app-sidebar-filter>
+    <app-sidebar-filter field="publishedCategory(id,name)" title="{{ 'CATEGORY' | translate}}" [filter]="filter" (checkboxFilter)="updateFilter('publishedCategory', $event)" ></app-sidebar-filter>
+    <app-sidebar-filter field="address(state)" title="{{ 'STATE' | translate}}" [filter]="filter" (checkboxFilter)="updateFilter('address(state)', $event)"></app-sidebar-filter>
+    <app-sidebar-filter field="address(city)" title="{{ 'CITY' | translate}}" [filter]="filter" (checkboxFilter)="updateFilter('address(city)', $event)"></app-sidebar-filter>
   </div>
 </ng-container>
 

diff --git a/src/static/i18n/en-GB.json b/src/static/i18n/en-GB.json
@@ -1,4 +1,5 @@
 {
   "NO_MATCHING_JOBS": "No matching vacancies",
-  "MISSING_JOB_ERROR": "Oops! The vacancy you are looking for is no longer here. Click okay to return to the vacancy list."
+  "MISSING_JOB_ERROR": "Oops! The vacancy you are looking for is no longer here. Click okay to return to the vacancy list.",
+  "STATE": "County"
 }
diff --git a/src/static/i18n/en.json b/src/static/i18n/en.json
@@ -25,6 +25,9 @@
   "ERROR_HAS_OCCURED": "An error has occurred while loading. Please refresh the page and try again.",
   "PAGE_DESCRIPTION": "View our careers",
   "FILTER": "Filter",
+  "CITY": "City",
+  "STATE": "State",
+  "CATEGORY": "Category",
   "EEOC" : {
     "EEOC_FORM_DESCRIPTION": "Voluntary Self-Identification Form for Race, Gender and Ethnicity",
     "GENDER_LABEL": "Gender",
@@ -52,4 +55,4 @@
     "DISABILITY_N": "No Disability",
     "DISABILITY_D": "I do not wish to self-identify"
   }
-}
+}
diff --git a/src/static/i18n/fr.json b/src/static/i18n/fr.json
@@ -25,6 +25,9 @@
   "ERROR_HAS_OCCURED": "Une erreur est survenue lors du chargement. Veuillez actualiser la page et réessayer.",
   "PAGE_DESCRITION": "Voir nos carrières",
   "FILTER": "Filtre",
+  "CITY": "Ville",
+  "STATE": "État / Région",
+  "CATEGORY": "Catégorie",
   "EEOC": {
     "EEOC_FORM_DESCRIPTION": "Formulaire volontaire d'auto-identification pour la race, le sexe et l'origine ethnique",
     "GENDER_LABEL": "Le genre",