cli: Make the CLI cgroups-aware #8234
Closed
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honoring cgroups limits on CPUs is useful when running `bb explain` in a workflow, such as in the "Compare" Bazel button.
bduffany
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Honoring cgroups limits on CPUs is useful when running
bb explainin a workflow, such as in the "Compare" Bazel button.
When the CLI is run within workflows, there are no cgroup hard limits applied. The CPU limit is effectively determined by the number of vCPUs that we allocate to the firecracker VM.
I think this change doesn't hurt though so I'd be cool with merging.
|
Interesting find along the way: https://news.ycombinator.com/item?id=42248550 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honoring cgroups limits on CPUs is useful when running
bb explainin a workflow, such as in the "Compare" Bazel button.