Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add "unsafe" tag to commands like reset that are considered unsafe #8646

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Wryhder
Copy link
Contributor

@Wryhder Wryhder commented Nov 18, 2024

Current behavior

Commands like reset (used for irreversible deletes of local state) should be advertised as dangerous but are currently not. See this comment for more details.

Proposed changes

Add an "unsafe" tag to such commands.

This PR is an extension of #8070 and it implements the suggestions in this comment.

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Wryhder Wryhder requested a review from a team as a code owner November 18, 2024 18:07
@Wryhder Wryhder marked this pull request as draft November 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant