test(rust): fix bats test on kafka-inlet args parsing

build-trust · Jan 9, 2025 · d77b328 · d77b328
1 parent bbcd779
commit d77b328
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/implementations/rust/ockam/ockam_command/src/kafka/inlet/create.rs b/implementations/rust/ockam/ockam_command/src/kafka/inlet/create.rs
@@ -217,7 +217,7 @@ impl CreateCommand {
             )?;
             if self.name != kafka_inlet_default_addr() {
                 opts.terminal.write_line(
-                    fmt_warn!("The <NAME> argument is being overridden by the --alias flag")
+                    fmt_warn!("The <NAME> argument is being overridden by the --addr flag")
                         + &fmt_log!("Consider removing the --addr flag"),
                 )?;
             }

diff --git a/implementations/rust/ockam/ockam_command/tests/bats/local/kafka.bats b/implementations/rust/ockam/ockam_command/tests/bats/local/kafka.bats
@@ -77,15 +77,21 @@ teardown() {
 }
 
 @test "kafka - create with deprecated alias --addr flag" {
+  # Ignore `name` if `addr` is also passed
   port="$(random_port)"
-
-  # Fail if both addr and name are used
-  run_failure $OCKAM kafka-inlet create kinlet-name --addr kinlet --to /secure/api --from $port --jq '.'
-
-  run_success $OCKAM kafka-inlet create --addr kinlet --to /secure/api --from $port --jq '.'
+  run_success $OCKAM kafka-inlet create kinlet-name --addr kinlet --to /secure/api --from $port --jq '.'
   assert_output --partial "\"from\": \"127.0.0.1:$port\""
   assert_output --partial "\"to\": \"/secure/api\""
 
   run_success $OCKAM kafka-inlet show kinlet --jq '.'
   assert_output --partial "kinlet"
+
+  # Use `addr`
+  port="$(random_port)"
+  run_success $OCKAM kafka-inlet create --addr kinlet2 --to /secure/api --from $port --jq '.'
+  assert_output --partial "\"from\": \"127.0.0.1:$port\""
+  assert_output --partial "\"to\": \"/secure/api\""
+
+  run_success $OCKAM kafka-inlet show kinlet2 --jq '.'
+  assert_output --partial "kinlet2"
 }