Merge pull request #24 from bugsnag/boolean-args

Better handling of boolean arguments

cli.js

@@ -59,6 +59,12 @@ const cli = meow(`
   string: [
     'app-version',
   ],
+  boolean: [
+    'overwrite',
+    'upload-node-modules',
+    'upload-sources',
+    'add-wildcard-prefix',
+  ],
 });
 
 const conf = {

index.js

@@ -297,6 +297,14 @@ function prepareRequest(options) {
       case 'tempDir': {
         break;
       }
+      case 'overwrite': {
+        // the presence of any value for this flag causes the API to interpret it as
+        // true, so only add it to the payload if it is truthy
+        if (options.overwrite) {
+          formData[name] = String(value);
+        }
+        break;
+      }
       // Basic fields (strings/booleans) & future fields
       default: {
         formData[name] = String(value);

index.test.js

@@ -3,6 +3,7 @@
 const stripProjectRoot = require('./index').stripProjectRoot
 const upload = require('./index').upload
 const validateOptions = require('./index').validateOptions
+const prepareRequest = require('./index').prepareRequest
 
 test('upload function exists', () => {
   expect(typeof upload).toBe('function');
@@ -71,3 +72,12 @@ describe('validateOptions', () => {
     }).toThrow('You must provide a path to the source map you want to upload.');
   });
 });
+
+describe('prepareRequest', () => {
+  test('removes options.overwrite when false', () => {
+    expect(prepareRequest({ overwrite: false }).formData).toEqual({});
+  });
+  test('does not remove options.overwrite when true', () => {
+    expect(prepareRequest({ overwrite: true }).formData).toEqual({ overwrite: 'true' });
+  });
+});