Add field and rule value to violations #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to access the captured rule and field value from a Violation.
C++ protobuf doesn't really have a native "value" representation unlike other languages, so I've created a sort-of stand-in. The
ProtoField
class acts as a reference to a field on a message, and provides an interface to get a singular value as avariant
. This should be good enough for most users, but users can also grab the information needed and use protobuf reflection directly instead if they have more complicated needs.This is a breaking change. The API changes in the following ways:
Validator::Validate()
now returns the wrapper typeValidationResult
instead ofViolations
. This can be converted into the protobufViolations
form using theproto()
method.ValidationResult.violations()
returns aConstraintViolation
. The underlyingViolation
can be accessed using theproto()
method.