Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose OneofInfo type #746

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Expose OneofInfo type #746

merged 2 commits into from
Mar 15, 2024

Conversation

q42jaap
Copy link
Contributor

@q42jaap q42jaap commented Mar 13, 2024

OneofInfo is a return type of FieldList.byMember. To avoid constructions like Extract<ReturnType<FieldList['byMember']>[0], { kind: 'oneof' }>;exposing the type is harmless.

@q42jaap
Expose OneofInfo type
50f6ddb 
OneofInfo is a return type of FieldList.byMember.
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

timostamm
timostamm approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're usually hesitant with adding exports, but it makes sense to export OneofInfo along with the other ...Info types.

@timostamm timostamm merged commit c0d0553 into bufbuild:main Mar 15, 2024
5 checks passed
@timostamm timostamm mentioned this pull request Apr 22, 2024
Merged
@trevormil trevormil mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q42jaap @CLAassistant @timostamm