Add tooling script to cache key #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In packages/upstream-protobuf, we're fetching `protoc` and other dependencies, and cache them based on the version. Since the logic of the script can affect the outcome, this is brittle. This PR adds the script itself to the cache key.
timostamm
commented
Nov 15, 2023
| @@ -43,7 +43,6 @@ async function main(args) { | |||
| exitUsage(); | |||
| } | |||
| stdout.write(protoInclude.files.join(" ")); | |||
| exit(0); | |||
There was a problem hiding this comment.
Unrelated. It's possible that Node.js exits before it has flushed what we wrote to stdout in the line above. Removing this line let's Node.js exit on its own.
gilwong00
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In packages/upstream-protobuf, we're fetching
protocand other dependencies, and cache them based on the version. Since the logic of the script can affect the outcome, this is brittle. This PR adds the script itself to the cache key.