Update isPackedFieldByDefault to return false if not PACKED

Instead of assuming that EXPANDED means that the field is not packed, be specific and check for PACKED, because it's unlikely but possible that more values are added to the enumeration in the future.
bufbuild · Nov 22, 2023 · 9ee344c · 9ee344c
1 parent 3836058
commit 9ee344c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/protobuf/src/create-descriptor-set.ts b/packages/protobuf/src/create-descriptor-set.ts
@@ -962,7 +962,7 @@ function isPackedFieldByDefault(
   resolveFeatures: FeatureResolverFn,
 ) {
   const { repeatedFieldEncoding } = resolveFeatures(file.edition);
-  if (repeatedFieldEncoding == FeatureSet_RepeatedFieldEncoding.EXPANDED) {
+  if (repeatedFieldEncoding != FeatureSet_RepeatedFieldEncoding.PACKED) {
     return false;
   }
   // From the proto3 language guide: