Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: tests for the message star actions #504

Merged
merged 2 commits into from
May 4, 2024
Merged

Messages: tests for the message star actions #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
551d1d9
Messages: add tests for message star actions
renatonascalves Apr 22, 2024
eecc20c
Merge branch 'master' into feature/message-star-tests
renatonascalves Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions includes/bp-messages/classes/class-bp-rest-messages-endpoint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,17 +568,6 @@ public function update_item_permissions_check( $request ) {
*/
public function update_starred( $request ) {
$message = $this->get_message_object( $request->get_param( 'id' ) );

if ( empty( $message->id ) ) {
return new WP_Error(
'bp_rest_invalid_id',
__( 'Sorry, this message does not exist.', 'buddypress' ),
array(
'status' => 404,
)
);
}

$user_id = bp_loggedin_user_id();
$result = false;
$action = 'star';
Expand Down Expand Up @@ -649,8 +638,24 @@ public function update_starred_permissions_check( $request ) {
)
);

if ( is_user_logged_in() ) {
$thread_id = messages_get_message_thread_id( $request->get_param( 'id' ) );
if ( ! is_user_logged_in() ) {
$retval = new WP_Error(
'bp_rest_authorization_required',
__( 'Sorry, you need to be logged in to star/unstar a message.', 'buddypress' ),
array(
'status' => rest_authorization_required_code(),
)
);
} else {
$thread_id = messages_get_message_thread_id( $request->get_param( 'id' ) ); // This is a message id.

if ( empty( $thread_id ) ) {
return new WP_Error(
'bp_rest_invalid_id',
__( 'Sorry, the thread of this message does not exist.', 'buddypress' ),
array( 'status' => 404 )
);
}

if ( messages_check_thread_access( $thread_id ) ) {
$retval = true;
Expand Down
66 changes: 63 additions & 3 deletions tests/testcases/messages/test-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Messages Endpoint Tests.
*
Expand Down Expand Up @@ -700,14 +701,73 @@ public function test_update_starred_remove_star() {
$this->bp->set_current_user( $u2 );

$request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/' . bp_get_messages_starred_slug() . '/' . $m->id );
$request->add_header( 'content-type', 'application/json' );
$response = $this->server->dispatch( $request );
$data = $response->get_data();
$data = reset( $data );
$data = current( $response->get_data() );

$this->assertFalse( $data['is_starred'] );
}

/**
* @group starred
*/
public function test_update_starred_user_is_not_logged_in() {
$u1 = $this->factory->user->create();
$u2 = $this->factory->user->create();

// Init a thread.
$m = $this->bp_factory->message->create_and_get( array(
'sender_id' => $u1,
'recipients' => array( $u2 ),
'subject' => 'Foo',
) );

$request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/' . bp_get_messages_starred_slug() . '/' . $m->id );

$this->assertErrorResponse(
'bp_rest_authorization_required',
$this->server->dispatch( $request ),
rest_authorization_required_code()
);
}

/**
* @group starred
*/
public function test_update_starred_user_with_no_access() {
$u1 = $this->factory->user->create();
$u2 = $this->factory->user->create();
$u3 = $this->factory->user->create();

// Init a thread.
$m = $this->bp_factory->message->create_and_get( array(
'sender_id' => $u1,
'recipients' => array( $u2 ),
'subject' => 'Foo',
) );

$this->bp->set_current_user( $u3 );

$request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/' . bp_get_messages_starred_slug() . '/' . $m->id );

$this->assertErrorResponse(
'bp_rest_authorization_required',
$this->server->dispatch( $request ),
rest_authorization_required_code()
);
}

/**
* @group starred
*/
public function test_update_starred_using_invalid_id() {
$this->bp->set_current_user( $this->user );

$request = new WP_REST_Request( 'PUT', $this->endpoint_url . '/' . bp_get_messages_starred_slug() . '/' . REST_TESTS_IMPOSSIBLY_HIGH_NUMBER );
$response = $this->server->dispatch( $request );

$this->assertErrorResponse( 'bp_rest_invalid_id', $response, 404 );
}

public function update_additional_field( $value, $data, $attribute ) {
return bp_messages_update_meta( $data->id, '_' . $attribute, $value );
}
Expand Down