Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): migrate @bundled-es-modules/deepmerge #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Neizan93
Copy link

@Neizan93 Neizan93 commented Aug 5, 2023

Migrated the deepmerge library to @bundled-es-modules/deepmerge.

fixes #229

Summary

This PR transitions from the deepmerge library to @bundled-es-modules/deepmerge, which is essentially the same library but exported as an ES module. This addresses the optimization warning observed with Angular 14 and subsequent versions.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines:
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Current Behavior

Using ngrx-store-localstorage with Angular 14 and later versions throws a warning related to the deepmerge dependency due to its CommonJS or AMD format. This warning indicates potential optimization bailouts.

Issue Number: #229

New Behavior

By moving to the @bundled-es-modules/deepmerge library, the optimization warning is mitigated. Users also have the advantage of sticking to a familiar library but with an ES module export.

Breaking Change?

  • Yes
  • No

Other information

The decision to shift to @bundled-es-modules/deepmerge was taken after assessing community feedback and aiming to maintain compatibility while embracing ES module standards.

Migrated the deepmerge library to @bundled-es-modules/deepmerge.

fixes btroncone#229
@Khaagar
Copy link

Khaagar commented Oct 23, 2023

Hi all, any news on this PR? Is there a chance that you merge it in near future? And update older versions (e.g. ng15) as well?

@Neizan93
Copy link
Author

Hi all, any news on this PR? Is there a chance that you merge it in near future? And update older versions (e.g. ng15) as well?

It is in @BBlackwo hands now

@BBlackwo BBlackwo added the dependencies Pull requests that update a dependency file label Feb 13, 2024
@BBlackwo
Copy link
Collaborator

Thanks for the PR @Neizan93! A couple of thoughts:

  1. It's difficult to verify the difference between the original deepmerge and @bundles-es-modules/deepmerge because it's not an actual Github fork. I'd like to verify it's the same apart from the export if possible.
  2. This package only has 2,400 weekly downloads whereas the original package has 19,033,310 so I'm a bit hesitant to migrate to a library that doesn't have much usage.
  3. If a few people could test this branch before merging that'd be great.

@HammamBM
Copy link

What about changing to this one? It does have more downloads and I've seen it mentioned on the ESM issue on deepmerge: https://www.npmjs.com/package/deepmerge-ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 14 deepmerge warning
5 participants