Skip to content

Commit

Permalink
chore: update
Browse files Browse the repository at this point in the history
  • Loading branch information
btlghrants committed Aug 28, 2024
1 parent eb77a18 commit e6031ab
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 14 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/semrel-02-rel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:

jobs:
rc:
permissions:
contents: write
if: ${{ github.event_name == 'workflow_dispatch' || github.event.pull_request.merged == true }}
uses: ./.github/workflows/semrel-rc.yml
soak:
Expand Down
30 changes: 16 additions & 14 deletions .github/workflows/semrel-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,6 @@ on:
workflow_call: # can be triggered by other workflows

jobs:
# - name: upload image tar artifact
# uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
# with:
# name: pepr-img.tar
# path: pepr-img.tar
# retention-days: 1

# - name: dowload image tar artifact
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
# with:
# name: pepr-img.tar
# path: ${{ github.workspace }}

check:
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -47,7 +34,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
needed=false
needle="There are no relevant changes, so no new version is released OOF."
needle="There are no relevant changes, so no new version is released."
if $(npm run sem-rel -- --dry-run | tee >(cat 1>&2) | grep --quiet "$needle")
then needed=false ; else needed=true
Expand All @@ -68,6 +55,21 @@ jobs:
echo "RELEASE_NEEDED=${{ needs.check.outputs.RELEASE_NEEDED }}"
# - name: upload image tar artifact
# uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
# with:
# name: pepr-img.tar
# path: pepr-img.tar
# retention-days: 1

# - name: dowload image tar artifact
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
# with:
# name: pepr-img.tar
# path: ${{ github.workspace }}


#
# TODO: works for steps... but what about stopping downstream jobs?
#
Expand Down

0 comments on commit e6031ab

Please sign in to comment.