Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exporting public key with QR code #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BBlackwo
Copy link
Contributor

@BBlackwo BBlackwo commented Feb 8, 2021

Updated the documentation to show how to export a public key from seedpicker using a QR code to improve the airgap.

Also:

  • Updated the link fomatting in the cobo-advanced page
  • Added a link in specter-advanced for Tor instructions

@@ -60,12 +60,7 @@ Expert users only: <https://github.com/mflaxman/human-rng-golang>
#### Improve Airgap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like me to remove this entire Improve Airgap section as it isn't really required anymore if you use a QR code instead of downloading the JSON file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense eventually, but for now QR isn't fully converged on. Hopefully soon!

@BBlackwo BBlackwo force-pushed the dev-bblackwo-improvements branch from e61c4ae to 6be4764 Compare February 8, 2021 11:50
Copy link
Contributor

@mflaxman mflaxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BBlackwo!

I think it's too early to move to QR exclusively, but making it the preferred route is a good idea. Does that make sense?

@@ -60,12 +60,7 @@ Expert users only: <https://github.com/mflaxman/human-rng-golang>
#### Improve Airgap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense eventually, but for now QR isn't fully converged on. Hopefully soon!

This is not currently documented.
Pull requests with clarification are welcome.
Specter-Desktop can receive this info via QR-code airgap.
DVDs are less able to execute malware on your computer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? Having an option A without an Option B is confusing.

I think we still want to list both options, until QR-code adoption is universal (many HW wallets with cameras for example). Some users are on desktops without webcams! Maybe we can make QR-code the preferred option?

@@ -57,9 +57,8 @@ zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo
#### Save the Output
1. Write down the whole 24 word phrase (`zoo` repeated 23 times + `buddy` as the 24th word) *offline* on paper only.
**Do not save this to any computer.**
1. Scroll down to `Export Public Key Info To Specter Desktop` and click on the `Download` button.
This will download a `json` file to your computer, containing the extended public key info.
Save the file to a DVD-R or USB drive to later share with Specter-Desktop.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think saving along the way is a good idea (even if not strictly required), so you can reverify on the display of each hardware wallet.

Maybe these steps need more detail? I've been waiting on a good 3rd hardware wallet.

@@ -72,11 +71,13 @@ See [advanced section](paper-advanced) for more info.


## Export Public Key Info to Specter-Desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need two separate steps (one for QR and one for doing it via a file)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. I'll update it to have 2 seperate steps so users can choose their preferred way.

@mmikeww
Copy link
Contributor

mmikeww commented Feb 10, 2021

Some people might have used Tails to generate the seed picker phrase. In that case, once the QR is displayed, you would want to take a picture of it with your cellphone, and then back on your specter installation, you would scan the cellphone picture with the computer webcam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants