Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to arma_cerr_stream<T> #278

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

eddelbuettel
Copy link
Contributor

Armadillo updates its coding convention over time. We have been fairly hard at work to have RcppArmadillo-using packages switch from a now-deprecated older way of instantiatig variables to a newer one (see issue #391 for details; this PR is part of the related issue #402).

When compiling packages using RcppArmadillo with the deprecation-warning-suppressor we still use, some new warnings come up. One concerns a deprecated way of setting an output or error stream as your package does in one spot in one file. Changing this is fairly straightforward, and affects only that one file.

The package compiles with the change as it did before, and test fine as well.

It would be much appreciated if you could apply this pull request and update the package at CRAN within the next few months. Let me know if you have any questions.

@bstewart
Copy link
Owner

Thanks so much for taking the time to do this @eddelbuettel and for all your contributions to the R community. I'll get this tested and pulled in soon and pushed to CRAN in the appropriate timeframe.

@eddelbuettel
Copy link
Contributor Author

Thanks for the very prompt reply!

@conradsnicta
Copy link

@bstewart A better solution is to simply remove all use of arma::set_cerr_stream(). No replacement code should be necessary.

Armadillo by default prints far fewer warnings since version 10.4, so use of arma::set_cerr_stream() is not required.

More details at: RcppCore/RcppArmadillo#402 (comment)

@bstewart bstewart merged commit 438b8b0 into bstewart:master Nov 30, 2023
FennecFish pushed a commit to FennecFish/scSTMseq that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants