Support Argon2id. #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is this PR waiting on? |
FauxFaux
added a commit
to FauxFaux/argon2min
that referenced
this pull request
Oct 21, 2018
|
It seems that there is a fork in https://github.com/FauxFaux/argon2min with this patch merged. @FauxFaux Do you plan to publish your argon2min crate? |
|
@ayosec: After review, I am not sufficiently confident in the code to publish it under my name, so not at this time, no. |
That's fair. Thanks for the response! For future readers: If you need Argon2id, the best (only?) option is argonautica, which uses the reference C implementation. |
|
@FauxFaux did you have time to do such a review? I'd love to be able to use a good fast Rust based implementation of argon2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.