Rework PNG Icon with SVG and SCSS #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation using `icon-fullscreen.png` and `icon-fullscreen-2x.png` for different screen (e.g. iOS with retina display). Moreover, we don't have any toggle effect for the icon status. This PR rework the icon with: * Locally vendor Font Awesome v5.15.4 `compress-solid.svg` and `expand-solid.svg` * Add default content for icon * Add toggle status for icon * Rework style with SCSS * Create minified version JS and CSS * Simplify demo and README.md with above changes Some style reuse from: domoritz/leaflet-locatecontrol#296 Online demo: https://drustack.github.io/brunob-leaflet.fullscreen/ Fix brunob#87 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
Thx for the PR, really appreciate :) but i think this is an oversized code change for a small functional change. I'd like to :
Anyway, i think the icon change on toggle is really needed change + the switch to a SVG icon (maybe we should use the one from https://github.com/Leaflet/Leaflet.fullscreen/blob/gh-pages/fullscreen.svg) |
|
My similar PR: Leaflet/Leaflet.fullscreen#118 My initial though are:
BTW, I also face a critical issue here:
Sorry that I will shift my focus back to using https://github.com/Leaflet/Leaflet.fullscreen (even it is inactive, I could using my patched version for my client project, now). |
brunob
added a commit
that referenced
this pull request
Dec 1, 2021
use icon from https://github.com/Leaflet/Leaflet.fullscreen optimised with https://jakearchibald.github.io/svgomg/ ref #97 & #87
brunob
added a commit
that referenced
this pull request
Dec 3, 2021
use icon from https://github.com/Leaflet/Leaflet.fullscreen optimised with https://jakearchibald.github.io/svgomg/ ref #97 & #87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation using
icon-fullscreen.pngandicon-fullscreen-2x.pngfor different screen (e.g. iOS with retina display). Moreover, we don't have any toggle effect for the icon status.This PR rework the icon with:
compress-solid.svgandexpand-solid.svgSome style reuse from: domoritz/leaflet-locatecontrol#296
Online demo: https://drustack.github.io/brunob-leaflet.fullscreen/
Fix #87
Signed-off-by: Wong Hoi Sing Edison [email protected]