-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance documentation #230
base: main
Are you sure you want to change the base?
Conversation
docs/ingestion/airtable.md
Outdated
- name: The name of the asset. | ||
|
||
- type: Specifies the type of the asset. Set this to ingestr to use the ingestr data pipeline. | ||
|
||
- connection: This is the destination connection, which defines where the data should be stored. For example: "postgres" indicates that the ingested data will be stored in a PostgreSQL database. | ||
|
||
**parameters:** | ||
- source_connection: The name of the airtable connection defined in .bruin.yml. | ||
|
||
- source_table: The name of the data table in airtable that you want to ingest. For example, "Details" is the table of airtable that you want to ingest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the extra spacing and put things within quotes:
- name: The name of the asset. | |
- type: Specifies the type of the asset. Set this to ingestr to use the ingestr data pipeline. | |
- connection: This is the destination connection, which defines where the data should be stored. For example: "postgres" indicates that the ingested data will be stored in a PostgreSQL database. | |
**parameters:** | |
- source_connection: The name of the airtable connection defined in .bruin.yml. | |
- source_table: The name of the data table in airtable that you want to ingest. For example, "Details" is the table of airtable that you want to ingest. | |
**Parameters:** | |
- `name`: The name of the asset. | |
- `type`: Specifies the type of the asset. Set this to ingestr to use the ingestr data pipeline. | |
- `connection`: This is the destination connection, which defines where the data should be stored. For example: `postgres` indicates that the ingested data will be stored in a PostgreSQL database. | |
- `source_connection`: The name of the Airtable connection defined in .bruin.yml. | |
- `source_table`: The name of the data table in Airtable that you want to ingest. For example, `details` is the table of airtable that you want to ingest. |
Careful with the syntax and casing.
docs/ingestion/airtable.md
Outdated
|
||
- source_table: The name of the data table in airtable that you want to ingest. For example, "Details" is the table of airtable that you want to ingest. | ||
|
||
**Step 3: [Run](https://bruin-data.github.io/bruin/commands/run.html) Asset to Ingest Data** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make these links relative:
**Step 3: [Run](https://bruin-data.github.io/bruin/commands/run.html) Asset to Ingest Data** | |
**Step 3: [Run](/commands/run.html) Asset to Ingest Data** |
docs/ingestion/airtable.md
Outdated
|
||
**Step 3: [Run](https://bruin-data.github.io/bruin/commands/run.html) Asset to Ingest Data** | ||
``` | ||
bruin run --file airtable_ingestion.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no --file
flag, you just give the right path:
bruin run --file airtable_ingestion.yml | |
bruin run assets/airtable_ingestion.yml |
docs/ingestion/airtable.md
Outdated
``` | ||
bruin run --file airtable_ingestion.yml | ||
``` | ||
It will ingest airtable data to postgres. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will ingest airtable data to postgres. | |
As a result of this command, Bruin will ingest data from the given Airtable table into your Postgres database. |
docs/ingestion/facebook-ads.md
Outdated
@@ -2,13 +2,13 @@ | |||
Facebook Ads is the advertising platform that helps users to create targeted ads on Facebook, Instagram and Messenger. | |||
ingestr supports Facebook-Ads as a source for [ingestr assets](https://bruin-data.github.io/bruin/assets/ingestr.html), allowing you to ingest data from Facebook-Ads into your data warehouse. | |||
|
|||
In order to have set up Facebook-Ads connection, you need to add a configuration item to `connections` in the `.bruin.yml` file complying with the following schema. For more information on how to get these credentials, read [here](https://bruin-data.github.io/ingestr/supported-sources/facebook-ads.html) | |||
In order to have set up Facebook-Ads connection, you need to add a configuration item in the `.bruin.yml` and `asset` file. You will also need `access token` and `accound id`. For more information on how to get these credentials, read [here](https://dlthub.com/docs/dlt-ecosystem/verified-sources/facebook_ads#setup-guide) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give the variable names as they should be written:
In order to have set up Facebook-Ads connection, you need to add a configuration item in the `.bruin.yml` and `asset` file. You will also need `access token` and `accound id`. For more information on how to get these credentials, read [here](https://dlthub.com/docs/dlt-ecosystem/verified-sources/facebook_ads#setup-guide) | |
In order to have set up Facebook-Ads connection, you need to add a configuration item in the `.bruin.yml` and `asset` file. You will also need `access_token` and `account_id`. For more information on how to get these credentials, please take a look at [here](https://dlthub.com/docs/dlt-ecosystem/verified-sources/facebook_ads#setup-guide). |
docs/ingestion/facebook-ads.md
Outdated
**Step 2: Create an Asset File for Data Ingestion** | ||
|
||
To ingest data from Facebook Ads, you need to create an [asset configuration file](https://bruin-data.github.io/bruin/assets/ingestr.html#template). This file defines the data flow from the source to the destination. Create a YAML file (e.g., facebook_ads_ingestion.yml) and add the following content: | ||
To ingest data from Facebook Ads, you need to create an [asset configuration](https://bruin-data.github.io/bruin/assets/ingestr.html#asset-structure) file. This file defines the data flow from the source to the destination. Create a YAML file (e.g., facebook_ads_ingestion.yml) and add the following content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make the links relative
docs/ingestion/hubspot.md
Outdated
|
||
Follow the steps below to correctly set up HubSpot as a data source and run ingestion. | ||
|
||
**Step 1: Add a Connection to .bruin.yml** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use sentence case in the titles
**Step 1: Add a Connection to .bruin.yml** | |
**Step 1: Add a connection to `.bruin.yml`** |
docs/ingestion/hubspot.md
Outdated
- api_key: The API key is used for authentication with the HubSpot API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the airtable parameters
docs/ingestion/s3.md
Outdated
|
||
- type: Specifies the type of the asset. Set this to ingestr to use the ingestr data pipeline. | ||
|
||
- connection: This is the destination connection, which defines where the data should be stored. For example: "postgres" indicates that the ingested data will be stored in a PostgreSQL database. | ||
|
||
**parameters:** | ||
- source_connection: The name of the S3 connection defined in .bruin.yml. | ||
|
||
- source_table: The name of the file or folder in S3 that you want to ingest. For example, 'students_details' would ingest data related to student details. | ||
|
||
**Step 3: [Run](https://bruin-data.github.io/bruin/commands/run.html) Asset to Ingest Data** | ||
``` | ||
bruin run --file s3_ingestion.yml | ||
``` | ||
It will ingest S3 data to postgres. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the airtable
No description provided.