feat: Use log/slog for logging to file or stdout #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Thank you so much. Does that test failure make sense? I haven't run the tests in so long, I'm not sure if it's your PR or just the test setup needs updating. |
|
That test should pass now. I hadn't switched out the frameLogger to slog fully. |
|
Nice. Could you squash the new commit? Then I'll get this merged. |
Switched to Go1.21 to use the log/slog package for strutctured logging. TODO: Log messages that are stringifying objects can now use strutctured output. TODO: Customise log levels for different messages. Fix tests
ananthb
force-pushed
the
go1.21-and-docs
branch
from
c74e47b to
92b440c
Compare
|
I have a few more improvements I'd like to do with logging. I can raise more PRs for those. |
|
So I think I'll wait for those then we can do a release. |
tombh
added a commit
that referenced
this pull request
Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461 * Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453 * remove unnecessary RUN command by @lpmi-13 in #466 * Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467 * fix: Golang install: use "amd64" for "x86_64" by @tombh in #463 * feat: Use log/slog for logging to file or stdout by @ananthb in #493 * feat: Structured log messages by @ananthb in #494 * chore: Clean up SETUP guides by @ananthb in #495 * chore: Remove manual install steps by @ananthb in #496 * fix: If debug is false discard logs by @ananthb in #497 * [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502 * feat: Add json schema (#505) by @Freed-Wu in #510 * @lpmi-13 made their first contribution in #466 * @ananthb made their first contribution in #493 * @Dragon1573 made their first contribution in #502 * @Freed-Wu made their first contribution in #510
Merged
tombh
added a commit
that referenced
this pull request
Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461 * Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453 * remove unnecessary RUN command by @lpmi-13 in #466 * Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467 * fix: Golang install: use "amd64" for "x86_64" by @tombh in #463 * feat: Use log/slog for logging to file or stdout by @ananthb in #493 * feat: Structured log messages by @ananthb in #494 * chore: Clean up SETUP guides by @ananthb in #495 * chore: Remove manual install steps by @ananthb in #496 * fix: If debug is false discard logs by @ananthb in #497 * [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502 * feat: Add json schema (#505) by @Freed-Wu in #510 * @lpmi-13 made their first contribution in #466 * @ananthb made their first contribution in #493 * @Dragon1573 made their first contribution in #502 * @Freed-Wu made their first contribution in #510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to Go1.21 to use the log/slog package for strutctured logging.
TODO: Log messages that are stringifying objects can now use strutctured output.
TODO: Customise log levels for different messages.