Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: non-option argument instead of --startup-url #230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

farhadmak
Copy link
Contributor

This pull request should complete #205 , Main updates:

  • Removed URL validation to accept links more freely.
  • Is able to accept strings to google search. ie. browsh "browsh documentation" will open a google search of the string.

@tombh
Copy link
Member

tombh commented Oct 26, 2018

Sorry for the delay. It's been so long since I looked at the code that I can't tell immediately what's going on. Is it easy to add a little test case? Hmm, maybe not, you'd have to do something hacky in this function I think. Anyway, if you think this is good to go, then I'll merge it.

@farhadmak
Copy link
Contributor Author

I'll look into writing up a test. A few things to note with this code, any argument without a flag will be opened into a new tab. If it is a link, then great, itll open to that link. If not, it does a google search on it. Off the top of your head, does this pose an issue? (i.e another command that has no flag)

@tombh tombh force-pushed the master branch 4 times, most recently from f290601 to 81f41b7 Compare June 19, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants