Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

feat: form to download redirects to BDR #77

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Jul 24, 2024

As of now, the redirect results in a "You must log in" page because we are waiting on OUC to provide a custom domain that we can use to tell the BDR that requests from this domain are permitted.

Removes the modal since we are not going to be tracking specific files.

@hetd54 hetd54 requested review from galenwinsor and broarr July 24, 2024 15:26
hetd54 added 4 commits July 24, 2024 11:32
Firebase-related APIs use API keys only to identify the Firebase project or app, not for authorization to call the API (like some other APIs allow). Authorization for Firebase-related APIs is handled separately from the API key, either through Google Cloud IAM permissions, Firebase Security Rules, or Firebase App Check. This is why it's OK to include Firebase API keys in your code when you use them only with Firebase-related APIs.
Copy link

github-actions bot commented Jul 24, 2024

Visit the preview URL for this PR (updated for commit 6c9fed7):

https://mmp-site-b1c9b--pr77-feat-download-to-bdr-2guu39u3.web.app

(expires Mon, 12 Aug 2024 16:57:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Curious what you think about the alternative approach to opening the new link.

src/components/DataForm.tsx Outdated Show resolved Hide resolved
@hetd54 hetd54 merged commit 2c073b0 into main Aug 6, 2024
2 checks passed
@hetd54 hetd54 deleted the feat-download-to-BDR branch August 6, 2024 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants