This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
feat: init pubs page #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 464be96): https://mmp-site-b1c9b--pr55-pubs-page-wi1p564n.web.app (expires Mon, 08 Jul 2024 20:53:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
galenwinsor
suggested changes
Jun 27, 2024
galenwinsor
suggested changes
Jul 1, 2024
src/components/Publications.tsx
Outdated
| paddingRight: "2rem", | ||
| }), | ||
| }} | ||
| onChange={(option) => setClassificationFilter(option as Array<iOption>)} |
There was a problem hiding this comment.
To make this work without the cast, you need to add an as const after the initial classifications value and type the state variable explicitly rather than implicitly. You'll also need to mark that type definition with Readonly<>. Let me know if that doesn't make sense!
Co-Authored-By: Galen Winsor <[email protected]>
galenwinsor
approved these changes
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will want to add the remaining pubs, but making a PR so that I can get comments on style!