Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Re-style layouts #48

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Re-style layouts #48

merged 7 commits into from
Jun 26, 2024

Conversation

hetd54
Copy link
Collaborator

@hetd54 hetd54 commented Jun 25, 2024

Restyling layouts to have a full-bleed layout (see https://www.joshwcomeau.com/css/full-bleed/) to better match figma layout design.

Closes #51

@hetd54 hetd54 requested a review from galenwinsor June 25, 2024 15:19
Copy link

github-actions bot commented Jun 25, 2024

Visit the preview URL for this PR (updated for commit bfcb401):

https://mmp-site-b1c9b--pr48-style-layouts-vc30ocdh.web.app

(expires Wed, 03 Jul 2024 19:13:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4eb870c89e876f1812e204af417359065d2a23b1

Copy link
Contributor

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few suggestions/thoughts.


body > * {
grid-column: 2;
@apply max-w-[1000px];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this with the new grid layout, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it results in this:

Screenshot 2024-06-26 at 2 49 14 PM

Copy link
Contributor

@galenwinsor galenwinsor Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not on my computer, weird...

Screenshot 2024-06-26 at 4 00 51 PM

src/styles/global.css Outdated Show resolved Hide resolved
src/components/Header.astro Show resolved Hide resolved
src/layouts/News.astro Outdated Show resolved Hide resolved
src/pages/news/index.astro Outdated Show resolved Hide resolved
@hetd54 hetd54 merged commit 47e09cf into main Jun 26, 2024
2 checks passed
@hetd54 hetd54 deleted the style-layouts branch June 26, 2024 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix central column width
2 participants