-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Visit the preview URL for this PR (updated for commit bfcb401): https://mmp-site-b1c9b--pr48-style-layouts-vc30ocdh.web.app (expires Wed, 03 Jul 2024 19:13:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few suggestions/thoughts.
|
||
body > * { | ||
grid-column: 2; | ||
@apply max-w-[1000px]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this with the new grid layout, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restyling layouts to have a full-bleed layout (see https://www.joshwcomeau.com/css/full-bleed/) to better match figma layout design.
Closes #51