This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Home page #45
Merged
Home page #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 5acae49): https://mmp-site-b1c9b--pr45-home-page-lwz6qtaj.web.app (expires Tue, 11 Jun 2024 17:37:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
galenwinsor
approved these changes
Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds content to home page from figma design
Additions
Components
HoverCard.tsx: uses radix ui hovercard primitive: https://www.radix-ui.com/primitives/docs/components/hover-card ; takes the trigger for the card as a prop
svg/Circle.tsx: Circle svg, takes color as a prop
svg/Footprint.tsx: all the footprints on the left side of the page
svg/MiniMaps.tsx: The home page's minimaps svg, also uses HoverCard component for the popover with contact info
Updates
Styles
global.css: Adds animation info for hovercard; @galenwinsor can you comment on lines 135 and 136? I didn't see an option in tailwind for opacity change
Layouts
Layout.astro: adds optional lede as prop; adds more padding to body to make space for the lede
index.astro: (the home page) adds content to match figma