Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python in Readme #87

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,14 @@ To add a new class:
- `-c`: class name (string)
- `-s`: class season/semester (fall, summer, spring)
- `-t`: target in docker file (string – `base`, `r_lang` or `r_julia`)
- `-p`: python version (i.e 3.7 if ommited defaults to 3.10)
- `-q`: wheter to install sqlite kernel (ommit the `-q` tag if sqlite is not required)
- `-p`: python version (i.e if ommited defaults to 3.9)
- `-q`: whether to install sqlite kernel (ommit the `-q` tag if sqlite is not required)

The example below shows creating a class specifying the python version. Omitting the `-p` argument will use the default version (currently 3.9). The default python is configured in the `add_class.sh`.
```bash
# e.g
cd dev/
./add_class.sh -c data1010 -t r_julia -s fall -p 3.7 -q
./add_class.sh -c data1010 -t r_julia -s fall -p 3.9 -q
```

To build the images locally:
Expand Down
2 changes: 1 addition & 1 deletion dev/add_class.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e

#default version of Python to use
PYTHON_VERSION=3.10
PYTHON_VERSION=3.9

usage () { echo "Usage:"
echo " -h – help"
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ services:
args:
CLASS: ${CLASS}
SQLITE: ${SQLITE:-false}
PYTHON_VERSION: ${PYTHON_VERSION:-3.10}
PYTHON_VERSION: ${PYTHON_VERSION:-3.9}
volumes:
- ./requirements/out:/home/jovyan/tmp/out
user: root
Expand Down