Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy firebase #145

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Deploy firebase #145

merged 6 commits into from
Jun 26, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jun 24, 2024

Add in Firebase configurations to deploy the Honeycomb Docs on Firebase (deployed through build folder after running npm run build)

@YUUU23 YUUU23 requested a review from RobertGemmaJr June 24, 2024 20:39
@YUUU23 YUUU23 linked an issue Jun 24, 2024 that may be closed by this pull request
@YUUU23 YUUU23 self-assigned this Jun 24, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the .gitignore? If you delete it and redo firebase it should go away

Copy link

Visit the preview URL for this PR (updated for commit c15a964):

https://ccv-honeycomb-docs--pr145-deploy-firebase-8h0mhkd5.web.app

(expires Wed, 03 Jul 2024 19:26:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d403a110fede5b0308678a87537bf61d0597aef6

Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@YUUU23 YUUU23 merged commit b32ad90 into main Jun 26, 2024
3 checks passed
@YUUU23 YUUU23 deleted the deploy-firebase branch June 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy as Firebase application
2 participants