chore: new accordion design for storage page #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d1f8584): https://qa-ccv-brown-edu--pr157-accordion-design-lgd6i10v.web.app (expires Thu, 26 Dec 2024 18:11:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a |
|
@hetd54 hmm... it still looks a bit more like a bulleted list (now with arrow bullets) than a drop-down. I wonder if something like this (screencap stolen from tailwind) makes more sense? |
eldu
approved these changes
Dec 11, 2024
Comment on lines
+12
to
+15
| <span v-if="expanded === false" class="icon"> | ||
| <i class="mdi mdi-plus mdi-24px" /> | ||
| </span> | ||
| <span v-else class="icon"> |
There was a problem hiding this comment.
This is nitpicky and just style, but there aren't that many. I'd rather it be
if truthy.... else ....
rather than if falsey .... else ....
just to simplify logical and relational operators
no worries though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qa-ccv-brown-edu--pr157-accordion-design-z5c51sjs.web.app/storage
Feedback from team: "One suggestion stood out: not everybody is figuring out that the arrows (bullets) used in 'Brown Storage Options' are actually dropdowns to get more information. Can we change them to 'Chevron up/down' icons OR '+/— in a circle' icon preceding the text?"
I made the entire storage-option its own separate box that is hoverable with a pointer -- do we think this new design effectively addresses their issue?