Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use data instead of route for title #151

Merged
merged 5 commits into from
Sep 10, 2024
Merged

test: use data instead of route for title #151

merged 5 commits into from
Sep 10, 2024

Conversation

hetd54
Copy link
Contributor

@hetd54 hetd54 commented Sep 9, 2024

This should fix the issue where changing the yml title for a route doesn't affect the title on the page (see https://github.com/brown-ccv/ccv-website-content/pull/284/files)

Copy link

github-actions bot commented Sep 9, 2024

Visit the preview URL for this PR (updated for commit 59beb41):

https://qa-ccv-brown-edu--pr151-test-subroutes-7usuq4kj.web.app

(expires Tue, 17 Sep 2024 19:54:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a

@hetd54 hetd54 requested review from eldu and s-bessey September 10, 2024 19:47
@hetd54 hetd54 marked this pull request as ready for review September 10, 2024 20:52
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING! Thank you so much heather !

@hetd54 hetd54 merged commit 68bd5ce into main Sep 10, 2024
2 checks passed
@hetd54 hetd54 deleted the test-subroutes branch September 10, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants