Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add max width to blog posts #142

Merged
merged 2 commits into from
Feb 7, 2024
Merged

feat: add max width to blog posts #142

merged 2 commits into from
Feb 7, 2024

Conversation

ashleysyg
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jan 29, 2024

Visit the preview URL for this PR (updated for commit d9b3c4a):

https://qa-ccv-brown-edu--pr142-feat-blog-format-as97d1uo.web.app

(expires Mon, 05 Feb 2024 19:37:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a

@ashleysyg ashleysyg self-assigned this Jan 29, 2024
@ashleysyg ashleysyg requested a review from galenwinsor January 29, 2024 18:59
pages/blog/_slug.vue Show resolved Hide resolved
pages/blog/_slug.vue Show resolved Hide resolved
@@ -36,3 +36,15 @@ export default {
},
};
</script>

<style>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something funky is happening with the switch to hamburger menu. Did this ever happen before? I'll investigate but you might immediately know what's causing this.

Screen.Recording.2024-01-29.at.2.08.34.PM.mov

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which browser are you using? i'm not seeing this behavior on chrome

@galenwinsor
Copy link

Okay I discovered a couple things:

  • The top red warning banner causes horizontal scrollbar. Adding a width: 100% to that fixes the issue.
  • The display: flex on .main-content on the blog page is causing horizontal overflow.
  • I think the width: auto on .container might also be causing horizontal scrollbar, but I think removing display: flex on .main-content fixes it.

@ashleysyg
Copy link
Member Author

Okay I discovered a couple things:

  • The top red warning banner causes horizontal scrollbar. Adding a width: 100% to that fixes the issue.
  • The display: flex on .main-content on the blog page is causing horizontal overflow.
  • I think the width: auto on .container might also be causing horizontal scrollbar, but I think removing display: flex on .main-content fixes it.

Which files are you referring to for:

  • adding width: 100% to fix horizontal scrolling in status bar
  • modifying .main-content

@galenwinsor
Copy link

Okay I discovered a couple things:

  • The top red warning banner causes horizontal scrollbar. Adding a width: 100% to that fixes the issue.
  • The display: flex on .main-content on the blog page is causing horizontal overflow.
  • I think the width: auto on .container might also be causing horizontal scrollbar, but I think removing display: flex on .main-content fixes it.

Which files are you referring to for:

* adding `width: 100%` to fix horizontal scrolling in status bar

* modifying `.main-content`

I guess .main-content is defined in _layout.scss and applies a lot of places. Maybe we could just override with another class? But also maybe it's a non issue since you're not seeing it. I'm using Firefox.

@galenwinsor galenwinsor self-requested a review January 31, 2024 16:39
Copy link

@galenwinsor galenwinsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashleysyg ashleysyg merged commit 17c4cb4 into main Feb 7, 2024
2 checks passed
@ashleysyg ashleysyg deleted the feat-blog-format branch February 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants