Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request storage button #140

Merged
merged 2 commits into from
Dec 14, 2023
Merged

feat: add request storage button #140

merged 2 commits into from
Dec 14, 2023

Conversation

ashleysyg
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 14, 2023

Visit the preview URL for this PR (updated for commit a57e8db):

https://qa-ccv-brown-edu--pr140-feat-storage-button-6en4wzcv.web.app

(expires Thu, 21 Dec 2023 16:12:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2def302adddb44a0a1eb29d07c5f8ac902277e8a

Copy link
Contributor

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are submitting the request, it isn't clear if the above questions have anything to do with the form -- do we want to stick the button above those sections if data doesn't get passed through to the Qual form?

Everything looks great ofc!

Screenshot 2023-12-14 at 10 41 30 AM

@ashleysyg
Copy link
Member Author

When you are submitting the request, it isn't clear if the above questions have anything to do with the form -- do we want to stick the button above those sections if data doesn't get passed through to the Qual form?

Everything looks great ofc!

Screenshot 2023-12-14 at 10 41 30 AM

That's a good point. Amar asked me to put the button either above or below the matrix. I put it above because I thought it might get lost at the very bottom of the page... but maybe the top of the page is a good place

@ashleysyg ashleysyg merged commit 6846681 into main Dec 14, 2023
2 checks passed
@ashleysyg ashleysyg deleted the feat-storage-button branch December 14, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants