Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: missing people images to logo #286

Merged
merged 4 commits into from
Sep 6, 2024
Merged

refactor: missing people images to logo #286

merged 4 commits into from
Sep 6, 2024

Conversation

eldu
Copy link
Contributor

@eldu eldu commented Sep 6, 2024

No description provided.

Copy link

github-actions bot commented Sep 6, 2024

Visit the preview URL for this PR (updated for commit 59eec63):

https://ccv-brown-edu--pr286-refactor-images-zvquboia.web.app

(expires Fri, 13 Sep 2024 17:00:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@eldu eldu requested review from hetd54 and paulstey September 6, 2024 16:47
@hetd54
Copy link
Contributor

hetd54 commented Sep 6, 2024

Screenshot 2024-09-06 at 12 48 36 PM @eldu I still see a few doggos

@eldu
Copy link
Contributor Author

eldu commented Sep 6, 2024

@hetd54 I did miss Paul Koussa! But it should be good now. It might be caching on your end? If you try in incognito you should see more logos!

Copy link
Contributor

@hetd54 hetd54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eldu eldu merged commit 7099633 into main Sep 6, 2024
12 checks passed
@eldu eldu deleted the refactor-images branch September 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants