Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: matrix #283

Merged
merged 3 commits into from
Sep 5, 2024
Merged

refactor: matrix #283

merged 3 commits into from
Sep 5, 2024

Conversation

eldu
Copy link
Contributor

@eldu eldu commented Aug 23, 2024

Remove redundant fields in the matrix. ‘Data Protection Replication’ and ’secondary site backup’.

Navigate to the storage page and then the comparison

Copy link

github-actions bot commented Aug 23, 2024

Visit the preview URL for this PR (updated for commit 59b9f26):

https://ccv-brown-edu--pr283-refactor-matrix-ywpiai8l.web.app

(expires Thu, 12 Sep 2024 18:10:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@eldu eldu requested review from paulstey, hetd54 and ashleysyg August 23, 2024 20:40
Copy link
Member

@paulstey paulstey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, Ellen!

I'm not sure Amar wanted both fields removed though. I understood that together they were redundant—not that they're both redundant. I might be wrong, though.

@eldu eldu changed the title Refactor: matrix refactor: matrix Aug 23, 2024
@eldu eldu requested a review from paulstey September 5, 2024 18:55
Copy link
Member

@paulstey paulstey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Ellen! Thank you so much!

@eldu eldu merged commit 3e7abd2 into main Sep 5, 2024
12 checks passed
@eldu eldu deleted the refactor-matrix branch September 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants