Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thomas Gordon to website #270

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Add Thomas Gordon to website #270

merged 4 commits into from
Jun 13, 2024

Conversation

metaterminal
Copy link
Contributor

No description provided.

@metaterminal metaterminal requested a review from michaeltu01 June 10, 2024 22:18
Copy link

github-actions bot commented Jun 10, 2024

Visit the preview URL for this PR (updated for commit 02066ad):

https://ccv-brown-edu--pr270-add-thomas-way2pqkl.web.app

(expires Thu, 20 Jun 2024 17:47:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@metaterminal metaterminal requested a review from eldu June 11, 2024 00:46
Copy link
Contributor

@eldu eldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

Take a look at conventional commits for future reference on commit messages!
https://www.conventionalcommits.org/en/v1.0.0/#summary

Copy link
Contributor

@michaeltu01 michaeltu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like you might need to resolve conflict before merging.

@metaterminal metaterminal merged commit c94cf6a into main Jun 13, 2024
12 checks passed
@metaterminal metaterminal deleted the add-thomas branch June 13, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants