-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dossantos am patch 1 #268
Dossantos am patch 1 #268
Conversation
Visit the preview URL for this PR (updated for commit 5cbbcb6): https://ccv-brown-edu--pr268-dossantos-am-patch-1-wuwkhj1a.web.app (expires Tue, 18 Jun 2024 14:43:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
@dossantos-am the assignee for this PR is you, can you add everyone else as reviewers? It's just above the assignee field. Also, this PR if you take a look at the files added tab, is just an image (amazing by the way!) . Remember to push your changes to the YAML file too ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in your about! However, if you look at the preview link (commented in the pr), your entry is not showing up.
Take a look at some YAML tutorials to better understand the structure. Here's one below!
https://gettaurus.org/docs/YAMLTutorial/
Also feel free to ask other interns for help! Code buddies is a great place too!
Also please change the title of your PR to something that better describes what this PR does.
You got this!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay... here I am rereviewing. the yaml looks okay i just realized your image should be renamed. Also you'll need 2 images !
images/people/IMG_8581.jpg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, i think you need to change this image name to austin_main.jpg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will do, I'll also get the second image in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what I did after renaming the image to austin_main.jpg but the image is gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you delete and re-add the image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded it and it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
For future PRs, make sure to name your PRs more specifically what the PR is about.
Also take a look at conventional commits!
https://www.conventionalcommits.org/en/v1.0.0/#summary
Great job!
Nice work, Austin! First PR right? Feel free to hit the Merge button now that this PR is approved. |
No description provided.