Add connor to website #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldu
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Great job! Take a look at the check that failed. It looks like it failed on validation. On the README, you can run the validations locally to check. Try that out and try to debug what's happening!
Also you'll need two images, one for the main and one for the hover.
|
Visit the preview URL for this PR (updated for commit 5938ce5): https://ccv-brown-edu--pr266-add-connor-to-websit-i1yibnqd.web.app (expires Mon, 24 Jun 2024 19:19:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
eldu
requested changes
Jun 14, 2024
about/people.yml
Outdated
| - name: Connor Holliday | ||
| type: Part Time | ||
| team: Advanced Research Computing | ||
| subteam: Graphics,Software and Data Core |
There was a problem hiding this comment.
Suggested change
| subteam: Graphics,Software and Data Core | |
| subteam: Graphics, Software and Data Core |
about/people.yml
Outdated
| github_username: connorholliday5 | ||
| brown_directory_uuid: 5ed99d55-cb88-4c46-aa54-64c1d1f3e71d | ||
| bio: Connor is a summer data intern working on the ice shelf stability project at CCV. He is a undergraduate student at Rhode Island College majoring in Computer Science.Outside of CCV you can find Connor,upgrading his gaming PC, working out or playing with his new puppy Penny. | ||
| image: Connor_Holliday.jpg |
There was a problem hiding this comment.
Suggested change
| image: Connor_Holliday.jpg | |
| image: Connor_Holliday_main.jpg |
images/people/Connor_Holliday.jpg
Outdated
There was a problem hiding this comment.
rename this to Connor_Holliday_main.jpg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of adding myself to the CCV website