Update vr-volume-viewer.md #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kmilo9999
commented
Sep 21, 2023
kmilo9999
commented
- Changed description and conclusion text
Changed description and conclusion text
|
Visit the preview URL for this PR (updated for commit 6440222): https://ccv-brown-edu--pr219-fix-camilo-blog-pzpwavhi.web.app (expires Fri, 29 Sep 2023 15:27:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e6225babbaf68dadb99b2906d33811740e5d15cb |
ashleysyg
reviewed
Sep 21, 2023
blog/vr-volume-viewer.md
Outdated
| @@ -60,6 +60,5 @@ This is a demo of the temperature and salinity of the Rhode Island narragansett | |||
| <p align="center"><img src="/content/images/blog/vr-volume-viewer/image5.gif"/></p> | |||
|
|
|||
| ### Conclusion | |||
| It is important to do research on the type of tools that could be used to easily visualize 3D data. However, it is vital to understand the rendering techniques and algorithms that those tools work with. Being able to implement ray marching helped our team to quickly develop a tool that adjusted to our own requirements and we can maintain following software engineer standards. | |||
|
|
|||
| It is important to research the types of tools available for easily visualizing 3D data. However, it's equally vital to understand the rendering techniques and algorithms these tools employ. Gaining an understanding of, and being able to implement, ray marching enabled our team to quickly develop a tool that meets our specific needs. This tool can be maintained according to established software engineering standards. | |||
There was a problem hiding this comment.
remove the comma after "implement". otherwise, looks great!
There was a problem hiding this comment.
@ashleysyg I applied your suggestions. Please review it.
removed missplaced coma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.