Changed build system to CMake #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current build system based on GNU make doesn't work correctly in Mac. I don't think it would work in other Unix systems as well, even though the code itself would have no problems working. By using CMake most of these problems can be avoided and tumble could be built in other systems with minimal effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current build system based on GNU make doesn't work correctly in Mac. I don't think it would work in other Unix systems as well, even though the code itself would have no problems working. By using CMake most of these problems can be avoided and tumble could be built in other systems with minimal effort.
I understand that several changes may be required before this can be merged, if at all. Just let me know any changes you would like to be made.
This also fixes #8