add detailed error message #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthelion
suggested changes
Dec 1, 2022
| @@ -83,9 +83,10 @@ def validate_response(self, response: requests.Response) -> None: | |||
| time.sleep(retry_after) | |||
| raise RetriableAPIError(msg) | |||
| elif 400 <= response.status_code < 500: | |||
| error_text = json.loads(response.text) | |||
There was a problem hiding this comment.
You can grab the response as a dict with response.json() so you don't have to parse the text yourself.
Another note here that because this catches all http codes between the range 400 and 500 they all might not have the error field which might cause the below part of error_text['error'] to fail with a KeyError. This can be worked around by using the get() method, which can handle default values in case of missing keys.
Merge main into branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include verbose error logging.