Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trino integration, tests and configurations #413

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Trino integration, tests and configurations #413

wants to merge 5 commits into from

Conversation

EminUZUN
Copy link

@EminUZUN EminUZUN commented Dec 18, 2023 •
edited
Loading

Overview

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

It adds support for trino

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A
  • Trino

@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 18, 2023 20:09 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 18, 2023 20:09 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 18, 2023 20:09 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 18, 2023 20:09 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:40 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:40 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:40 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:40 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:51 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:51 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:51 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 13:51 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 14:19 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 14:19 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 14:19 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests December 19, 2023 14:19 — with GitHub Actions Failure
@EminUZUN
Copy link
Author

EminUZUN commented Dec 19, 2023 •
edited
Loading

I have run main branch test package: https://github.com/EminUZUN/dbt_artifacts/actions/runs/7263229785/job/19788068739
It run for 1_5_0 and above

I used memory connector for testing, ci test package failed, as this connector does not support schema evolution etc. But locally I could run against iceberg without any problem.
https://github.com/EminUZUN/dbt_artifacts/actions/runs/7263159204

@EminUZUN
Copy link
Author

Hey @glsdown, is this project alive? Or will it be retired?

@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests January 26, 2024 11:14 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests January 26, 2024 11:14 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests January 26, 2024 11:14 — with GitHub Actions Failure
@EminUZUN EminUZUN had a problem deploying to Approve Integration Tests January 26, 2024 11:14 — with GitHub Actions Failure
@danielyahn
Copy link

@EminUZUN @glsdown any chance this can be merged?

DenGodunov
DenGodunov reviewed Aug 8, 2024
View reviewed changes
Copy link

@DenGodunov DenGodunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done correctly

@DenGodunov
Copy link

@glsdown please review changes?

@netanelm-upstream
Copy link

@glsdown Any update on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenGodunov DenGodunov DenGodunov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EminUZUN @danielyahn @DenGodunov @netanelm-upstream