add redshift support #406
Open
add redshift support #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
hanslemm
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
hanslemm
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
hanslemm
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
hanslemm
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding Redshift support - seems like with the new changes this is fairly trivial. The only issue I had running the test suite was the one described in #60.
Which is trivially solvable (not necessarily in a nice way) by adding redshift specific dispatches for string type helpers that return a varchar(max).
Update type - breaking / non-breaking
What does this solve?
#60
Adding super basic redshift support as per issue 60.
Outstanding questions
It's a bit clunky using varchar(max) for these types, but it solves the issue without needing to know what the maximum possible length of each text field is and having a special dispatch which takes the length (that other databases don't care about).
And imo it's better to just add this support and then someone can optimise this later if they have a problem with varchar(max).
What databases have you tested with?