Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit 8f3a8e0738f10de5b2387443c3960f5c3a3a38a8
Merge: 21d59d3 82792e0
Author: Joshua Neman <[email protected]>
Date:   Mon Nov 16 15:52:11 2020 -0400

    Merge pull request #2 from brooklyn-data/add/looker-pr-template

    Create looker modeling pr template

commit 82792e0a05b1ba6c649b25b9214b9b725e08428f
Author: Joshua Neman <[email protected]>
Date:   Fri Nov 6 16:36:30 2020 -0400

    Update pr_templates/looker_modeling_pr.md

    Co-authored-by: Alexis <[email protected]>

commit 257712d7953df80df37682f23d73463164fb5233
Author: Joshua Neman <[email protected]>
Date:   Wed Nov 4 15:47:10 2020 -0400

    Update pr_templates/looker_modeling_pr.md

    Co-authored-by: Alexis <[email protected]>

commit 2b2caf1f71b11f8050af6e5ca11229697bae902e
Author: Joshua Neman <[email protected]>
Date:   Wed Nov 4 15:41:55 2020 -0400

    Update pr_templates/looker_modeling_pr.md

    Co-authored-by: Alexis <[email protected]>

commit 12a303695184063aafbc0b7698c4429f3a5c0669
Author: Joshua Neman <[email protected]>
Date:   Wed Nov 4 15:41:16 2020 -0400

    Update pr_templates/looker_modeling_pr.md

    Co-authored-by: Alexis <[email protected]>

commit b344089b59d39885949efec934fa00a46052bbf4
Author: Joshua Neman <[email protected]>
Date:   Wed Nov 4 15:40:35 2020 -0400

    Update pr_templates/looker_modeling_pr.md

    Co-authored-by: Alexis <[email protected]>

commit 21d59d33c1a7f4bc866d488f105fd6026f114120
Author: Eli Kastelein <[email protected]>
Date:   Tue Nov 3 17:08:27 2020 -0800

    Add a section about where to put filters during an inner join (#1)

commit 9eaf7851995398de39469fb7a821473d73c82b9f
Author: Joshua Neman <[email protected]>
Date:   Wed Oct 21 10:59:16 2020 -0400

    Create looker_modeling_pr.md

    Adding a suggested Looker modeling PR template to:
    - document in a central source
    - facilitate sharing with clients
  • Loading branch information
joshuaneman committed Nov 16, 2020
1 parent c3789b5 commit 98b982e
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions pr_templates/looker_modeling_pr.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
## Overview
_Summarize the goal of your work and what motivated it._

## Key changes
- _Describe major updates._

## Other notes
- _List open questions and other things your reviewer should know._

## Related links
- _List links to related ticket(s)._
- _(optional) Link to other files and resources, such as specific related reports in Looker or PRs in the dbt repo._

## QA
- _Describe how you evaluated the accuracy of the results (e.g. "picked these 10 IDs from source system and compared aggregated values and compared overall summary to July report")_
- _List links to QA-related items, e.g. to a SQL file used to compare outputs to some benchmark and a file that is reporting on the same topic._

## Checklist
- [ ] Communicating with users:
- [ ] All added / modified files create new features (e.g., Looks, Explores, Dashboards, fields, elements) that will not impact existing stakeholder workflow(s).
- [ ] This PR may / will impact existing stakeholder workflow(s) and there is a stakeholder communication plan in place.
- [ ] LookML model(s) connection(s) reverted to production.

## Screenshots
_Include screenshots that demonstrate the new feature(s)._

0 comments on commit 98b982e

Please sign in to comment.