getDestFilePath is called on Filter and not subclasses

[ghedamat]

this avoids a bug where a subclass implementation has side-effect

e.g. broccoli assets rev

/cc @elucid

[ghedamat]

Or.. If we think this is intended. We can try to patch broccoli-asset-rev and remove the side effects there if we think this should be how getDestFilePath works (by calling the subclass implementation)

[rwjblue]

In general, we should call the instances method (what this does currently on master).

Also, In chatting with @elucid I believe that he mentioned that getDestPath was being called for all files regardless of exclusion/inclusion, which seems wrong (we should investigate).

[ghedamat]

@rwjblue agreed,

happy to close this and try a better path

[stefanpenner]

this seems fishy, so the idea is getDestFilePath cannot be refined by subclasses?

[ghedamat]

Yeah. But the more we think about it the more it feels wrong.

I think we'll have to change the implementation in asset-rev instead.

I'm inclined to close this pr for now c/d?

[rwjblue]

Ya, confirm.

[elucid]

@rwjblue @stefanpenner PR to update broccoli-asset-rev is here: ember-cli/broccoli-asset-rev#93

/cc @ghedamat