[DDO-3785] Ignore suitability within Sherlock

[jack-r-warren]

I'll remove it from the API and then the database at a later junction. Requires all other PRs for DDO-3785 to be merged first.

Testing

Updated tests to all reference roles rather than suitability. Had more than I thought, I thought I updated tests before, but I'm not arguing.

Risk

Low

[jyang-broad]

removes "suitability" as a top-level attribute, now lives somewhere in roles.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
13.3% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

No API changes detected

[github-actions]

Published image from 6c3e8fb (merge 97ee658):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.5.24-97ee658
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.5.24-97ee658

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (ca1a760) to head (6c3e8fb).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   69.62%   69.64%   +0.02%     
==========================================
  Files         272      272              
  Lines       12370    12355      -15     
==========================================
- Hits         8612     8605       -7     
+ Misses       2880     2871       -9     
- Partials      878      879       +1     

Files	Coverage Δ
sherlock/internal/models/cluster.go	90.00% <ø> (-1.31%)	⬇️
sherlock/internal/models/environment.go	62.30% <ø> (-0.59%)	⬇️
sherlock/internal/models/user.go	86.81% <ø> (+2.65%)	⬆️
sherlock/internal/oidc_models/storage.go	64.97% <100.00%> (+0.09%)	⬆️

... and 1 file with indirect coverage changes