Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3781] Improve account linking notification #600

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

jack-r-warren
Copy link
Contributor

Adds an additional notification coming from the User upsert endpoint to better broadcast account linking information.

Testing

Mocked tests updated

Risk

Very low

@jack-r-warren jack-r-warren requested a review from a team as a code owner July 9, 2024 20:40
Copy link

sonarqubecloud bot commented Jul 9, 2024

Copy link

github-actions bot commented Jul 9, 2024

No API changes detected

Copy link

github-actions bot commented Jul 9, 2024

Published image from 3e8deec (merge fa82d1b):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.5.14-fa82d1b
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.5.14-fa82d1b

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (b3f5783) to head (3e8deec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   76.32%   76.36%   +0.03%     
==========================================
  Files         210      210              
  Lines        9945     9959      +14     
==========================================
+ Hits         7591     7605      +14     
  Misses       1684     1684              
  Partials      670      670              
Files Coverage Δ
sherlock/internal/api/sherlock/users_v3_upsert.go 90.38% <100.00%> (+1.49%) ⬆️

@jack-r-warren jack-r-warren merged commit 8606a16 into main Jul 9, 2024
18 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3781-account-linking-notif branch July 9, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants