-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDO-3763] Do CORS from Sherlock #590
Conversation
No API changes detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
+ Coverage 77.65% 77.71% +0.05%
==========================================
Files 203 206 +3
Lines 9572 9610 +38
==========================================
+ Hits 7433 7468 +35
- Misses 1489 1491 +2
- Partials 650 651 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
2cb6b18
to
17343c8
Compare
Quality Gate passedIssues Measures |
Details in the ticket.
This does the CORS thing that we've been having the proxy do so far. Benefit now is that we can actually just pass the list of origins and it filters based on them, without treating them like a vulnerable regex like Apache does. Argument for this approach is that it's simpler.
We also move the CSRF mitigations from the proxy into Sherlock for the same reasons.
Two chart changes are required for this to work: we'll need to pass the origins into Sherlock's config and we'll need to configure the proxy to not mutate the Host/Origin headers so that this new middleware can see the real values.
Testing
Via unit test, my own manual testing, and most importantly, Sarah Gibson's testing from her pentest tools
Risk
Low