Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3641] Rework for required checks #543

Merged
merged 3 commits into from
May 1, 2024

Conversation

jack-r-warren
Copy link
Contributor

@jack-r-warren jack-r-warren commented May 1, 2024

The GHA in this repo are very fancy... so fancy that it actually makes it impossible to use GitHub's "require the following checks before merge to main," because whether a check would run was always dependent on the code the PR changed.

This PR adjusts the PR-run checks to always run on PRs, even if not strictly necessary, so we can gate on them easier.

This PR also makes a few other tweaks:

  • Configures Dependabot to include an "ongoing" ticket in its commit messages
  • Configures the build action to check that client libraries can be built when run in a PR
  • Reorders the build steps slightly to initiate the GCP auth after commits have already been made, as an extra bonus protection against committing GCP credentials
  • Renames GitHub Actions to make the folder a bit easier to read (since humans do read it!)
  • Adds a very simple action to check if PR titles contain a ticket

@jack-r-warren jack-r-warren requested a review from a team as a code owner May 1, 2024 18:20
Copy link

github-actions bot commented May 1, 2024

No API changes detected

Copy link

github-actions bot commented May 1, 2024

Published image from d66b6c5 (merge b883f07):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.3.25-b883f07
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.3.25-b883f07

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jack-r-warren jack-r-warren merged commit f0a4b2f into main May 1, 2024
13 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3641-prepare-for-required-checks branch May 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants