-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDO-3279: Remove "v2_" from more foreign keys #368
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What's Changed
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## DDO-3315-chart-release-statuses #368 +/- ##
================================================================
Coverage 69.22% 69.22%
================================================================
Files 159 159
Lines 10500 10500
================================================================
Hits 7269 7269
Misses 2737 2737
Partials 494 494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but the branch is out of date)
Testing
I tested this locally by
migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 61
and
migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 62
to test down and up, respectively.