Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3279: Remove "v2_" from more foreign keys #368

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

katiewelch
Copy link
Contributor

@katiewelch katiewelch commented Nov 21, 2023

Testing
I tested this locally by

  1. starting up my local Sherlock. Doing this will run all the migrations and fail if there are any errors.
Screenshot 2023-11-27 at 11 06 27 AM
  1. using the golang-migrate/migrate tool to test run my up and down migrations. I used
    migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 61
    and
    migrate -path sherlock/db/migrations -database 'postgres://sherlock:password@localhost:5432/sherlock?sslmode=disable' goto 62
    to test down and up, respectively.
Screenshot 2023-11-27 at 11 07 28 AM

@katiewelch katiewelch requested a review from a team as a code owner November 21, 2023 20:36
@katiewelch katiewelch changed the base branch from main to DDO-3315-chart-release-statuses November 21, 2023 20:36
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

What's Changed


GET /api/ci-identifiers/v3
Parameters:

Added: resourceStatus in query

Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Added property resourceStatus (string)

      Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

    • Changed property ciRuns (array)

      Changed items (object):

      • Added property resourceStatus (string)

        Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/ci-identifiers/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Added property resourceStatus (string)

      Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

    • Changed property ciRuns (array)

      Changed items (object):

      • Added property resourceStatus (string)

        Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/ci-runs/v3
Parameters:

Added: resourceStatus in query

Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Added property resourceStatus (string)

      Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

    • Changed property relatedResources (array)

      Changed items (object):

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

PUT /api/ci-runs/v3
Request:

Changed content type : application/json

  • Added property chartReleaseStatuses (object)

    Keys treated like chartReleases. Values set resource-specific statuses for chart releases and associated changesets, new app versions, and new chart versions.

Return Type:

Changed response : 201 Created

Created

  • Changed content type : application/json

    • Added property resourceStatus (string)

      Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

    • Changed property relatedResources (array)

      Changed items (object):

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

GET /api/ci-runs/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Added property resourceStatus (string)

      Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

    • Changed property relatedResources (array)

      Changed items (object):

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

GET /api/app-versions/v3
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PUT /api/app-versions/v3
Return Type:

Changed response : 201 Created

Created

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/app-versions/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PATCH /api/app-versions/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/chart-versions/v3
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PUT /api/chart-versions/v3
Return Type:

Changed response : 201 Created

Created

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/chart-versions/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PATCH /api/chart-versions/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/charts/v3
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

POST /api/charts/v3
Return Type:

Changed response : 201 Created

Created

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/charts/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

DELETE /api/charts/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PATCH /api/charts/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/clusters/v3
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    Changed items (object):

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

POST /api/clusters/v3
Return Type:

Changed response : 201 Created

Created

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/clusters/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

DELETE /api/clusters/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

PATCH /api/clusters/v3/{selector}
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property ciIdentifier (object)

      • Added property resourceStatus (string)

        Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

      • Changed property ciRuns (array)

        Changed items (object):

        • Added property resourceStatus (string)

          Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/app-versions/procedures/v3/changelog
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property changelog (array)

      Changed items (object):

      • Changed property ciIdentifier (object)

        • Added property resourceStatus (string)

          Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

        • Changed property ciRuns (array)

          Changed items (object):

          • Added property resourceStatus (string)

            Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

GET /api/chart-versions/procedures/v3/changelog
Return Type:

Changed response : 200 OK

OK

  • Changed content type : application/json

    • Changed property changelog (array)

      Changed items (object):

      • Changed property ciIdentifier (object)

        • Added property resourceStatus (string)

          Available only when querying a CiIdentifier via a CiRun, indicates the status of the run for that resource

        • Changed property ciRuns (array)

          Changed items (object):

          • Added property resourceStatus (string)

            Available only when querying a CiRun via a CiIdentifier, indicates the status of the run for that resource

Copy link

Published image from caa6d8b (merge 6b277ae):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.45-6b277ae

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #368 (caa6d8b) into DDO-3315-chart-release-statuses (d510602) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           DDO-3315-chart-release-statuses     #368   +/-   ##
================================================================
  Coverage                            69.22%   69.22%           
================================================================
  Files                                  159      159           
  Lines                                10500    10500           
================================================================
  Hits                                  7269     7269           
  Misses                                2737     2737           
  Partials                               494      494           

Base automatically changed from DDO-3315-chart-release-statuses to main November 27, 2023 14:25
Copy link
Contributor

@jack-r-warren jack-r-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but the branch is out of date)

@katiewelch katiewelch merged commit 58dee68 into main Nov 27, 2023
15 checks passed
@katiewelch katiewelch deleted the DDO-3279-more-v2-renames branch November 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants